Fix: weird issue #18010
Closed
Fix: weird issue #18010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Mar 10, 2025
| } else if (OP1_TYPE != IS_CONST && | ||
| OP2_TYPE == IS_CONST && | ||
| EXPECTED(CACHED_PTR(opline->result.num) == ce)) { | ||
| fbc = CACHED_PTR(opline->result.num + sizeof(void*)); |
There was a problem hiding this comment.
If you look at the implementation of CACHED_PTR:
#define CACHED_PTR(num) \
((void**)((char*)EX(run_time_cache) + (num)))[0]As you can see, num is used as an byte offset into EX(run_time_cache). That's why we add sizeof(void*) instead of 1, we want to load the next pointer after the one pointed to by opline->result.num.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes some code that appears to be a bug. I think it was intended to be
CACHED_PTR(opline->result.num + 1);? I'm not sure why we are incrementing an integer by the sizeof a pointer.There are a couple other instances of this in this file, but I wanted to bring it up first, to understand why it is here.