Skip to content

remove wrappers in session ext #18017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

remove wrappers in session ext #18017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cc969
removed wrappers around functions
jorgsowa Mar 8, 2025
6769f21
reverted useful comments
jorgsowa Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions ext/session/mod_user_class.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
RETURN_FALSE; \
}

/* {{{ Wraps the old open handler */
PHP_METHOD(SessionHandler, open)
{
char *save_path = NULL, *session_name = NULL;
Expand All @@ -60,9 +59,7 @@ PHP_METHOD(SessionHandler, open)

RETURN_BOOL(SUCCESS == ret);
}
/* }}} */

/* {{{ Wraps the old close handler */
PHP_METHOD(SessionHandler, close)
{
zend_result ret;
Expand All @@ -84,9 +81,7 @@ PHP_METHOD(SessionHandler, close)

RETURN_BOOL(SUCCESS == ret);
}
/* }}} */

/* {{{ Wraps the old read handler */
PHP_METHOD(SessionHandler, read)
{
zend_string *val;
Expand All @@ -104,9 +99,7 @@ PHP_METHOD(SessionHandler, read)

RETURN_STR(val);
}
/* }}} */

/* {{{ Wraps the old write handler */
PHP_METHOD(SessionHandler, write)
{
zend_string *key, *val;
Expand All @@ -119,9 +112,7 @@ PHP_METHOD(SessionHandler, write)

RETURN_BOOL(SUCCESS == PS(default_mod)->s_write(&PS(mod_data), key, val, PS(gc_maxlifetime)));
}
/* }}} */

/* {{{ Wraps the old destroy handler */
PHP_METHOD(SessionHandler, destroy)
{
zend_string *key;
Expand All @@ -134,9 +125,7 @@ PHP_METHOD(SessionHandler, destroy)

RETURN_BOOL(SUCCESS == PS(default_mod)->s_destroy(&PS(mod_data), key));
}
/* }}} */

/* {{{ Wraps the old gc handler */
PHP_METHOD(SessionHandler, gc)
{
zend_long maxlifetime;
Expand All @@ -153,9 +142,7 @@ PHP_METHOD(SessionHandler, gc)
}
RETURN_LONG(nrdels);
}
/* }}} */

/* {{{ Wraps the old create_sid handler */
PHP_METHOD(SessionHandler, create_sid)
{
zend_string *id;
Expand All @@ -170,4 +157,3 @@ PHP_METHOD(SessionHandler, create_sid)

RETURN_STR(id);
}
/* }}} */
Loading
Loading