nitpick time_sleep_until_basic.phpt #18021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was randomly failing on my windows-WSL linux system. remove rounding of target time. remove rounding of tolerance on windows, it looked dodgy. hardcode tolerance rather than dynamically adjusting, makes it easier to reason about. Only tested on WSL-Linux as of writing, but the github CI should do the rest.
|
The FreeBSD and MacOS wakeups are late by 74-106MS, enough to wonder if there actually is something wrong with the time_sleep_until implementation on these platforms 🤔 for comparison, Windows (the OS I expected to do worst) wakeup is late by <50ms, and the Linux wakeups are late by <10ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was randomly failing on my windows-WSL-linux system. (I suspect it was because target time was rounded? Didn't figure out exactly why)
Only tested on WSL-Linux as of writing, but the github CI should do the rest.