ext/standard/dir.c: Refactor implementation of Directory and dir functions #18088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
dir_refactoring
branch
from
8e48e3d to
e2565cf
Compare
nielsdos
requested changes
Apr 1, 2025
ext/standard/dir.c
Outdated
| { | ||
| zval *handle_zv = Z_DIRECTORY_HANDLE_P(this_z); | ||
| if (UNEXPECTED(Z_TYPE_P(handle_zv) != IS_RESOURCE)) { | ||
| zend_throw_error(NULL, "internal directory stream has been altered"); |
There was a problem hiding this comment.
Shouldn't this be a type error (same below)? Doesn't matter much.
Also shouldn't the error messages start with capital letter (as they're not argument errors)
There was a problem hiding this comment.
I don't know if this should be a TypeError, as normally a non-initialized object is an Error
There was a problem hiding this comment.
It doesn't matter much, fine by me.
|
CI failures are legit |
nielsdos
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.