Skip to content

Conversation

@DanielEScherzer
Copy link
Member

No description provided.

DanielEScherzer referenced this pull request Mar 26, 2025
While internally enums are mostly the same as classes, their output in
`ReflectionClass::__toString()` should show the enum as the developer wrote it,
rather than as the engine stored it. Accordingly

- Say that the enum is an enum, not a final class

- Include the backing type, if any, in the declaration line

- List enum cases separately from constants, and show the underlying values, if
any

GH-15766
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ship it

@DanielEScherzer DanielEScherzer merged commit 36ae82b into php:master Mar 26, 2025
2 checks passed
@DanielEScherzer DanielEScherzer deleted the reflection-enum-news branch March 28, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants