Implement Closure::getCurrent() to retrieve current closure #18167
+89
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Mar 28, 2025
mvorisek
reviewed
Mar 28, 2025
|
|
||
| $c(1); | ||
| var_dump($i); | ||
|
|
There was a problem hiding this comment.
Closure in attribute should be tested as well.
Also probably a "fail" in class method and no function in global context.
mvorisek
reviewed
Mar 28, 2025
TimWolla
reviewed
Apr 1, 2025
azjezz
added a commit
to carthage-software/mago
that referenced
this pull request
Jul 21, 2025
This commit introduces support for the new `Closure::getCurrent()` method, available in PHP 8.5 (implemented in php/php-src#18167 ). A special function handler has been implemented to correctly analyze calls to this method. When used within a closure or arrow function, the analyzer now correctly infers the return type as the signature of the current closure. This enables precise type-checking for recursive anonymous functions. Additionally, the analyzer will now emit an `InvalidStaticMethodCall` error if `Closure::getCurrent()` is used outside of a valid closure context (e.g., in the global scope or within a regular method/function), aligning with PHP's runtime behavior. The internal PHP stubs have also been updated to include this new method. Signed-off-by: azjezz <[email protected]>
azjezz
added a commit
to carthage-software/mago
that referenced
this pull request
Jul 27, 2025
This commit introduces support for the new `Closure::getCurrent()` method, available in PHP 8.5 (implemented in php/php-src#18167 ). A special function handler has been implemented to correctly analyze calls to this method. When used within a closure or arrow function, the analyzer now correctly infers the return type as the signature of the current closure. This enables precise type-checking for recursive anonymous functions. Additionally, the analyzer will now emit an `InvalidStaticMethodCall` error if `Closure::getCurrent()` is used outside of a valid closure context (e.g., in the global scope or within a regular method/function), aligning with PHP's runtime behavior. The internal PHP stubs have also been updated to include this new method. Signed-off-by: azjezz <[email protected]>
11 tasks
|
Why not making it a static virtual property via a get hook? |
|
Static properties don't support hooks. It would also be confusing to return different values from a static property depending on context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-18163
This is a much simpler alternative to https://wiki.php.net/rfc/closure_self_reference.