Skip to content

Get rid of temporary in array_push #18181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025
+4 −5
Merged

Get rid of temporary in array_push #18181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3502,8 +3502,7 @@ static void php_splice(HashTable *in_hash, zend_long offset, zend_long length, H
PHP_FUNCTION(array_push)
{
zval *args, /* Function arguments array */
*stack, /* Input array */
new_var; /* Variable to be pushed */
*stack; /* Input array */
uint32_t argc; /* Number of function arguments */


Expand All @@ -3514,10 +3513,10 @@ PHP_FUNCTION(array_push)

/* For each subsequent argument, make it a reference, increase refcount, and add it to the end of the array */
for (uint32_t i = 0; i < argc; i++) {
ZVAL_COPY(&new_var, &args[i]);
Z_TRY_ADDREF(args[i]);

if (zend_hash_next_index_insert(Z_ARRVAL_P(stack), &new_var) == NULL) {
Z_TRY_DELREF(new_var);
if (zend_hash_next_index_insert(Z_ARRVAL_P(stack), &args[i]) == NULL) {
Z_TRY_DELREF(args[i]);
zend_throw_error(NULL, "Cannot add element to the array as the next element is already occupied");
RETURN_THROWS();
}
Expand Down
Loading