Implement GH-18261: Allow cast to be used in constant expressions #18264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Apr 6, 2025
mvorisek
reviewed
Apr 6, 2025
mvorisek
reviewed
Apr 6, 2025
iluuu1994
approved these changes
Apr 10, 2025
UPGRADING
Outdated
| RFC: https://wiki.php.net/rfc/marking_return_value_as_important | ||
| . Added asymmetric visibility support for static properties. | ||
| RFC: https://wiki.php.net/rfc/static-aviz | ||
| . It is now possible to use casts in constant expressions. |
There was a problem hiding this comment.
Nit: "Added support for casts in constant expressions" for consistency?
mvorisek
reviewed
Apr 10, 2025
| case IS_OBJECT: | ||
| zend_cast_zval_to_object(result, &op1, IS_VAR); | ||
| break; | ||
| EMPTY_SWITCH_DEFAULT_CASE(); |
There was a problem hiding this comment.
what about the new (void) cast?
There was a problem hiding this comment.
Void casts are not allowed in expression context, only when their return value is not used. This never applies to constant expressions. This is also a different ast type (ZEND_AST_CAST_VOID), so it doesn't need to be handled here.
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Apr 17, 2025
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Apr 17, 2025
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.