Skip to content

Conversation

@devnexen
Copy link
Member

@devnexen devnexen commented Apr 6, 2025

mostly litespeed SAPI.

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although it doesn't cause a build error, would it be better to make the same correction in the following places as well?

void (*sig_handler)() = NULL;

mostly litespeed SAPI.
@devnexen devnexen force-pushed the fix_build_warnings branch from cdfa719 to 762557e Compare April 17, 2025 05:44
@devnexen devnexen merged commit ba83d5d into php:master Apr 19, 2025
8 of 9 checks passed
@devnexen devnexen deleted the fix_build_warnings branch April 19, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants