run-tests.php: Save STDIN section into a file #18305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ayesh I do it already :) |
|
My bad, sorry. I deleted my comment to reduce noise. About the change, it's straight forward and makes sense. I also had trouble re-running some failing tests, and having stdin ready to reuse would have saved a lot of time! |
Ayesh
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test has an
--STDIN--or--PHPDBG--section, save the section's content into a file, like we do for the other sections.This makes it bit easier to reproduce these tests outside of
run-tests.php.This doesn't update the
.shfile to pass the file as stdin to the program, yet.When using
gdb, we can pass the file as stdin like this: