Fix GH-18281: making flock flags mutually exclusive. #18315
Draft
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
gh18281
branch
3 times, most recently
from
2b64d98 to
1ad40e5
Compare
mvorisek
reviewed
Apr 12, 2025
ext/standard/file.c
Outdated
| static inline bool php_is_valid_flock_flag(zend_long s) { | ||
| const zend_long sb = s & ~PHP_LOCK_NB; | ||
| return (sb == PHP_LOCK_UN || sb == PHP_LOCK_SH || | ||
| sb == PHP_LOCK_EX || s == -1); |
There was a problem hiding this comment.
It seems to be an accepted value (a test uses it) even tough it does nothing. I may discard it.
There was a problem hiding this comment.
In my understanding -1 flag implies all flags set, thus more than 1 exclusive flag set, thus it should not be allowed and hence this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposing a standard way to detect bitwise values through a new Zend entry.