Skip to content

Conversation

@AkameOuO
Copy link

According to the rfc3986 Section 3.1:

Scheme names consist of a sequence of characters beginning with a
letter and followed by any combination of letters, digits, plus
("+"), period ("."), or hyphen ("-").

parse_url currently accepts schemes that start with non-alphabetic characters.

@AkameOuO AkameOuO changed the base branch from master to PHP-8.3 April 17, 2025 09:26
@iluuu1994
Copy link
Member

See https://wiki.php.net/rfc/url_parsing_api. parser_url is heavily used for invalid URLs, and past changes have lead to unintended BC breaks (which you can see in your own PR). Instead, we're planning to add RFC3986 (and WHATWG) compliant parsers that do not accept invalid URLs.

@AkameOuO
Copy link
Author

I see. Sorry I didn't notice that

@AkameOuO AkameOuO closed this Apr 18, 2025
@iluuu1994
Copy link
Member

No worries! Thanks for your PR nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants