ext/openssl: various arrays optimisations. #18377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-allocated sizes and/or packed arrays.
bukka
reviewed
Apr 21, 2025
ext/openssl/openssl.c
Outdated
Comment on lines
1078
to
1079
| array_init_size(&subsub, 3); | ||
| zend_hash_real_init_packed(Z_ARRVAL(subsub)); |
There was a problem hiding this comment.
if this gives visible performance improvement, why don't you create array_init variants (e.g. array_init_packed and array_init_size_packed)?
There was a problem hiding this comment.
I just might. Not huge differences by any mean but I ran those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-allocated sizes and/or packed arrays.