Skip to content

Removed <mmintrin.h> #18414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Removed <mmintrin.h> #18414

merged 1 commit into from
Apr 24, 2025

Conversation

@SakiTakamachi
Copy link
Member

If <emmintrin.h> is loaded, <mmintrin.h> is not required.

@SakiTakamachi SakiTakamachi marked this pull request as ready for review April 24, 2025 04:55
@SakiTakamachi SakiTakamachi requested a review from dstogov as a code owner April 24, 2025 04:55
nielsdos
nielsdos approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed included implicitly via emmintrin.h

@SakiTakamachi SakiTakamachi merged commit 6c09c16 into php:master Apr 24, 2025
9 checks passed
@SakiTakamachi SakiTakamachi deleted the rm_mmintrin_inc branch April 24, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees

No one assigned

Labels

ABI break Category: Engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SakiTakamachi @nielsdos