Skip to content

Fix GH-18421: Integer overflow with large numbers in LimitIterator #18424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-18421: Integer overflow with large numbers in LimitIterator #18424

wants to merge 1 commit into from

Conversation

@nielsdos
Copy link
Member

Since we already know that pos < intern->u.limit.offset at this point, we can reverse the expression.

@nielsdos nielsdos requested a review from Girgias as a code owner April 24, 2025 18:07
@nielsdos nielsdos linked an issue Apr 24, 2025 that may be closed by this pull request
Integer overflow with large numbers in LimitIterator #18421
Closed
@nielsdos
Fix phpGH-18421: Integer overflow with large numbers in LimitIterator
b5c3138 
Since we already know that `pos < intern->u.limit.offset` at this point,
we can reverse the expression.
@nielsdos nielsdos closed this in a91d913 Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: spl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integer overflow with large numbers in LimitIterator

2 participants

@nielsdos @Girgias