Skip to content

Fix reference handling in cancel callback #18439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

Fix reference handling in cancel callback #18439

merged 1 commit into from
Apr 27, 2025

Conversation

@nielsdos
Copy link
Member

Broke in 8765e9f

@nielsdos nielsdos requested a review from Girgias April 26, 2025 21:48
Girgias
Girgias approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

References do be a pain :|

@nielsdos nielsdos merged commit 1ec9041 into php:master Apr 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: zip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nielsdos @Girgias