Skip to content

ext/intl: use RETURN_NEW_STR for intl_get*id_windows_id(). #18501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

ext/intl: use RETURN_NEW_STR for intl_get*id_windows_id(). #18501

merged 1 commit into from
May 4, 2025

Conversation

@devnexen
Copy link
Member

@devnexen devnexen commented May 4, 2025

for non interned return values.

nielsdos
nielsdos approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like intl_convert_utf16_to_utf8 always creates a new string indeed.

@devnexen devnexen merged commit 9ac5b04 into php:master May 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees

No one assigned

Labels

Extension: intl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devnexen @nielsdos