Fix leak of accel_globals->key #18593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why this was guarded with ZTS, but it leaks on this test (and a few more): `./sapi/cli/php ./run-tests.php -c . --show-diff sapi/phpdbg/tests/stdin_001.phpt`
dstogov
approved these changes
May 19, 2025
iluuu1994
approved these changes
May 19, 2025
There was a problem hiding this comment.
I didn't call it for non-ZTS in #17576 because LSan doesn't consider allocations reachable through globals lost. I don't understand the details of why it does for sapi/phpdbg/tests/stdin_001.phpt, but it doesn't seem harmful to free it unconditionally.
I'm also confused as to why this isn't caught by CI. phpdbg is tested in the ASan build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this was guarded with ZTS, but it leaks on this test (and a few more):
./sapi/cli/php ./run-tests.php -c . --show-diff sapi/phpdbg/tests/stdin_001.phptThe same issue exists on 8.3 but needs a bit of a different fix, which I'll do after this is approved.