Skip to content

ext/mysqli: Use zval_is_true() instead of converting to boolean #18682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

ext/mysqli: Use zval_is_true() instead of converting to boolean #18682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
961a251
ext/mysqli: Add test for mysqli_object_has_property() object handler
Girgias May 29, 2025
2cdee17
ext/mysqli: Use zval_is_true() instead of converting to boolean
Girgias May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/mysqli/mysqli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ static int mysqli_object_has_property(zend_object *object, zend_string *name, in
zval rv;
zval *value = mysqli_read_property(object, name, BP_VAR_IS, cache_slot, &rv);
if (value != &EG(uninitialized_zval)) {
convert_to_boolean(value);
has_property = Z_TYPE_P(value) == IS_TRUE;
has_property = zval_is_true(value);
zval_ptr_dtor(value);
}
break;
}
Expand Down
13 changes: 13 additions & 0 deletions ext/mysqli/tests/mysqli_object_has_property.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
--TEST--
Test mysqli_object_has_property() internal object handler
--EXTENSIONS--
mysqli
--FILE--
<?php
$driver = new mysqli_driver();
var_dump(isset($driver->client_info));
var_dump(empty($driver->client_info));
?>
--EXPECT--
bool(true)
bool(false)