zend_ast: Preserve heredocs in zend_ast_export() #18690
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
May 28, 2025
| zend_ast_export_str(str, Z_STR_P(zv)); | ||
| smart_str_appendc(str, '\''); | ||
| if (ast->attr & ZEND_NAME_HEREDOC) { | ||
| smart_str_appends(str, "<<<HEREDOC\n"); |
There was a problem hiding this comment.
Suggested change
| smart_str_appends(str, "<<<HEREDOC\n"); | |
| smart_str_appends(str, "<<<'EOD'\n"); |
TimWolla
reviewed
May 28, 2025
Comment on lines
+9
to
+11
| <<<HTML | ||
| val inside | ||
| HTML |
There was a problem hiding this comment.
What would happen if:
- The string contains a line
HEREDOC? - The string contains special characters that would be escaped by
zend_ast_export_str()?
Is it guaranteed that the output is valid PHP in all cases?
There was a problem hiding this comment.
I'll cover these with tests, thanks.
TimWolla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now just with HEREDOC name