zend_opcode: eliminate free loop

[xepozz]

idk if it's valid, but tests pass without it

[iluuu1994]

Have you ran ext/zend_test/tests/attribute_arguments.phpt for example? You probably didn't compile with zend_test.

[xepozz]

You probably didn't compile with zend_test

how to do it?

[iluuu1994]

--enable-zend-test

[xepozz]

I did

./configure --enable-debug --with-iconv=$(brew --prefix libiconv) --enable-zend-test
make TEST_PHP_ARGS=-j8 test

which results to

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    42 (gmp, ftp, dl_test, calendar, snmp, sysvshm, sockets, sysvmsg, intl, sysvsem, dba, ldap, skeleton, readline, mysqlnd, bz2, pdo_odbc, soap, zlib, pdo_mysql, zip, curl, enchant, tidy, pdo_pgsql, ffi, odbc, gettext, mysqli, exif, pgsql, gd, sodium, pcntl, com_dotnet, shmop, openssl, xsl, bcmath, pdo_dblib, pdo_firebird, mbstring)
Exts tested     :    29
---------------------------------------------------------------------

Number of tests : 20717             15009
Tests skipped   :  5708 ( 27.6%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     1 (  0.0%) (  0.0%)
Expected fail   :     9 (  0.0%) (  0.1%)
Tests passed    : 14999 ( 72.4%) ( 99.9%)
---------------------------------------------------------------------
Time taken      : 63.747 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Do not inherit LC_CTYPE from environment [ext/ctype/tests/lc_ctype_inheritance.phpt]
=====================================================================

You may have found a problem in PHP.
This report can be saved and used to open an issue on the bug tracker at
https://github.com/php/php-src/issues
This gives us a better understanding of PHP's behavior.
Do you want to save this report in a file? [Yn]: n
make: *** [test] Error 1

[iluuu1994]

Internal leaks are not detected by the integrated leak detector. You need ASan/LSan or Valgrind to detect this leak. We'll see if the ASan build fails.

[iluuu1994]

As expected, the tests confirm the leak. Hence, I'm closing this.