Skip to content

Mysqli last query error #18728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+57 −0
Open

Mysqli last query error #18728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1533ea
Add last_query_error property to mysqli for query error tracking
Jun 1, 2025
84f457e
Add patch: last_query_error property to mysqli to store failed query
Jun 1, 2025
96765f2
Add .phpt test for last_query_error property on failed mysqli queries
Jun 1, 2025
7ffffbf
rimozione last_query_error.phpt
Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/mysqli/mysqli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,9 @@ PHP_MINIT_FUNCTION(mysqli)

mysqlnd_reverse_api_register_api(&mysqli_reverse_api);

/* Declare 'last_query_error' property to store last failed query */
zend_declare_property_null(mysqli_link_class_entry, "last_query_error", sizeof("last_query_error")-1, ZEND_ACC_PUBLIC);

return SUCCESS;
}
/* }}} */
Expand Down
4 changes: 4 additions & 0 deletions ext/mysqli/mysqli_nonapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,8 @@ PHP_FUNCTION(mysqli_query)
if (resultmode & MYSQLI_ASYNC) {
if (mysqli_async_query(mysql->mysql, query, query_len)) {
MYSQLI_REPORT_MYSQL_ERROR(mysql->mysql);
/* Save failed query string to 'last_query_error' */
zend_update_property_string(Z_OBJCE_P(ZEND_THIS), Z_OBJ_P(ZEND_THIS), "last_query_error", sizeof("last_query_error")-1, query);
RETURN_FALSE;
}
mysql->async_result_fetch_type = resultmode & ~MYSQLI_ASYNC;
Expand All @@ -611,6 +613,8 @@ PHP_FUNCTION(mysqli_query)

if (mysql_real_query(mysql->mysql, query, query_len)) {
MYSQLI_REPORT_MYSQL_ERROR(mysql->mysql);
/* Save failed query string to 'last_query_error' */
zend_update_property_string(Z_OBJCE_P(ZEND_THIS), Z_OBJ_P(ZEND_THIS), "last_query_error", sizeof("last_query_error")-1, query);
RETURN_FALSE;
}

Expand Down
50 changes: 50 additions & 0 deletions mysqli_last_query_error.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
From c1533ea2ebf4e712383616312dc4b260aa3b3d95 Mon Sep 17 00:00:00 2001
From: dome <[email protected]>
Date: Sun, 1 Jun 2025 13:19:43 +0200
Subject: [PATCH] Add last_query_error property to mysqli for query error
tracking

---
ext/mysqli/mysqli.c | 3 +++
ext/mysqli/mysqli_nonapi.c | 4 ++++
2 files changed, 7 insertions(+)

diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c
index a8a75eff70..0d063e624e 100644
--- a/ext/mysqli/mysqli.c
+++ b/ext/mysqli/mysqli.c
@@ -535,6 +535,9 @@ PHP_MINIT_FUNCTION(mysqli)

mysqlnd_reverse_api_register_api(&mysqli_reverse_api);

+ /* Declare 'last_query_error' property to store last failed query */
+ zend_declare_property_null(mysqli_link_class_entry, "last_query_error", sizeof("last_query_error")-1, ZEND_ACC_PUBLIC);
+
return SUCCESS;
}
/* }}} */
diff --git a/ext/mysqli/mysqli_nonapi.c b/ext/mysqli/mysqli_nonapi.c
index e0e14eeccb..4e210a32ea 100644
--- a/ext/mysqli/mysqli_nonapi.c
+++ b/ext/mysqli/mysqli_nonapi.c
@@ -603,6 +603,8 @@ PHP_FUNCTION(mysqli_query)
if (resultmode & MYSQLI_ASYNC) {
if (mysqli_async_query(mysql->mysql, query, query_len)) {
MYSQLI_REPORT_MYSQL_ERROR(mysql->mysql);
+ /* Save failed query string to 'last_query_error' */
+ zend_update_property_string(Z_OBJCE_P(ZEND_THIS), Z_OBJ_P(ZEND_THIS), "last_query_error", sizeof("last_query_error")-1, query);
RETURN_FALSE;
}
mysql->async_result_fetch_type = resultmode & ~MYSQLI_ASYNC;
@@ -611,6 +613,8 @@ PHP_FUNCTION(mysqli_query)

if (mysql_real_query(mysql->mysql, query, query_len)) {
MYSQLI_REPORT_MYSQL_ERROR(mysql->mysql);
+ /* Save failed query string to 'last_query_error' */
+ zend_update_property_string(Z_OBJCE_P(ZEND_THIS), Z_OBJ_P(ZEND_THIS), "last_query_error", sizeof("last_query_error")-1, query);
RETURN_FALSE;
}

--
2.43.0

Loading