Skip to content

Conversation

@mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jun 1, 2025

@SakiTakamachi
Copy link
Member

I don’t think we should make changes to php-src just for unbundled extensions.

Wouldn’t it be sufficient to simply copy the tests to the oci repository?

@mvorisek
Copy link
Contributor Author

mvorisek commented Jun 1, 2025

We should, we expect some common behaviour and maintaining more or less copied code is never a good idea. Here this was changes in PHP 8.4 to fix collision in CI, we keep this feature but change the table names to be below 30 characters. Other tests are passing.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle 11g release 2 was release in September 2009 and had its final release in August 2013. It is also considered EOL by Oracle.
And as of Oracle 12.2, which was released in August 2017 and is also EOL table names can be 128 bytes.

I am against changes in php-src to support EOL software.

@mvorisek
Copy link
Contributor Author

mvorisek commented Jun 2, 2025

In my personal opinion it is not a problem to support EOL software per se as long as the support is easy.

Also, I would be happy if you, Gina, would be happy to unblock me as we both participate at amazing software but cooperating with you in interactions you get into is challenging, I get no notifications, I cannot comment on your PRs etc.

@mvorisek mvorisek closed this Jun 2, 2025
@mvorisek mvorisek deleted the fix_too_long_identifier_in_tests_for_pdo_oci branch June 2, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants