ext/iconv: fix iconv tests got skipped on windows #18802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyh19962008
changed the title
|
Intuitively it seems to me that the quotes should be dropped from the constant, but deferring this to cmb |
|
I think it would be better not to change that constant value, cause it has been there since 2003. People might have codes depend on it. |
nielsdos
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows(with php 8.4.7 NTS-x64), if you run
php -r "var_dump(ICONV_IMPL);", the result is like this:So, the translit-failure.phpt and translit-utf8.phpt tests currently would be skipped on Windows.