[RFC] FILTER_THROW_ON_FAILURE #18896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
changed the title
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
8c5abca to
86969e5
Compare
divinity76
reviewed
Jun 22, 2025
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
86969e5 to
10dab9e
Compare
divinity76
reviewed
Jul 6, 2025
Contributor
|
LGTM fwiw. (I don't have access use the actual github review form on php-src, but it lgtm.) |
derickr
reviewed
Jul 14, 2025
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
5e658f7 to
e16eb44
Compare
DanielEScherzer
referenced
this pull request
Jul 15, 2025
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
e16eb44 to
af6b103
Compare
Member
Author
|
Rebased for conflict from #19073 |
iluuu1994
reviewed
Aug 20, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Seems like we should have at least a simple successful test using FILTER_THROW_ON_FAILURE.
ext/filter/tests/throw-on-failure/filter_var_array_failure.phpt
Outdated
Show resolved
Hide resolved
Member
Author
Done |
iluuu1994
approved these changes
Aug 21, 2025
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
a84affd to
0c5d337
Compare
Ayesh
added a commit
to Ayesh/polyfill
that referenced
this pull request
Nov 19, 2025
…xception` PHP 8.5 adds two new exception classes, along with the new `FILTER_THROW_ON_FAILURE` flag. We can not polyfill the exception behavior (which is activated with the `FILTER_THROW_ON_FAILURE` flag), but we can still polyfill the exception classes. - [RFC](https://wiki.php.net/rfc/filter_throw_on_failure) - [PR](php/php-src#18896) - [`Filter\FilterException`](https://php.watch/versions/8.5/filter-validation-throw-exception#FilterException), [codex](https://php.watch/codex/Filter/FilterException) - [`Filter\FilterFailedException`](https://php.watch/versions/8.5/filter-validation-throw-exception#FilterFailedException), [codex](https://php.watch/codex/Filter/FilterFailedException)
Ayesh
added a commit
to Ayesh/polyfill
that referenced
this pull request
Nov 19, 2025
…xception` PHP 8.5 adds two new exception classes, along with the new `FILTER_THROW_ON_FAILURE` flag. We can not polyfill the exception behavior (which is activated with the `FILTER_THROW_ON_FAILURE` flag), but we can still polyfill the exception classes. - [RFC](https://wiki.php.net/rfc/filter_throw_on_failure) - [PR](php/php-src#18896) - [`Filter\FilterException`](https://php.watch/versions/8.5/filter-validation-throw-exception#FilterException), [codex](https://php.watch/codex/Filter/FilterException) - [`Filter\FilterFailedException`](https://php.watch/versions/8.5/filter-validation-throw-exception#FilterFailedException), [codex](https://php.watch/codex/Filter/FilterFailedException)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/filter_throw_on_failure