Skip to content

ext/random: Remove ZPP tests and make the those tests a bit useful #18920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

ext/random: Remove ZPP tests and make the those tests a bit useful #18920

merged 1 commit into from
Jun 23, 2025

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Jun 23, 2025

No description provided.

TimWolla
TimWolla approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests can also be removed entirely, since the seeding is tested by ext/random/tests/01_functions/mt_rand_value.phpt (and srand() is just an alias).

@Girgias
Copy link
Member Author

Girgias commented Jun 23, 2025

The tests can also be removed entirely, since the seeding is tested by ext/random/tests/01_functions/mt_rand_value.phpt (and srand() is just an alias).

ACK will just remove then

@Girgias Girgias merged commit c7f0ac1 into php:master Jun 23, 2025
8 of 9 checks passed
@Girgias Girgias deleted the random-tests branch June 23, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla TimWolla approved these changes

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi is a code owner

Assignees

No one assigned

Labels

Extension: random

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Girgias @TimWolla