Better size check in bzdecompress

[marc-mabe]

• unsigned long long is equivalent to unsigned __int64 according to https://learn.microsoft.com/en-us/cpp/cpp/data-type-ranges?view=msvc-170
• comparing / casting ull to size_t has nothing to do with zend_long
• use %zu to format an unsigned integer of size_t

[marc-mabe]

@Girgias ping you here as you have the most commits for this ext in the last year

[Girgias]

This does look reasonable to me, but maybe @cmb69 has better input about the Window's specific code that use to exist?

[cmb69]

Thanks for the PR! The code seems to be improvable, indeed.

However, why don't we use uint64_t instead of unsigned long long? From .total_out_hi32 and bzs.total_out_lo32 it's pretty clear that we have to deal with 64bit integers, anyway. Also, I'm not sure that the preprocessor guards are really relevant (performance wise), but if we keep them, we might better use https://github.com/php/php-src/blob/master/Zend/zend_range_check.h (either something suitable is already there, or we can add something).

[marc-mabe]

Thanks for the PR! The code seems to be improvable, indeed.

However, why don't we use uint64_t instead of unsigned long long? From .total_out_hi32 and bzs.total_out_lo32 it's pretty clear that we have to deal with 64bit integers, anyway. Also, I'm not sure that the preprocessor guards are really relevant (performance wise), but if we keep them, we might better use https://github.com/php/php-src/blob/master/Zend/zend_range_check.h (either something suitable is already there, or we can add something).

@cmb69 true, I updated the PR in favor of uint64_t and removed the preprocessor checks. This may leave us with an impossible condition but my guess is that this would get optimized out anyway. Also added an UNEXPECTED here.