Make cloning DOM node lists, maps, and collections fail #19089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This never worked and creates a broken object, and on master can cause a crash with foreach. It makes no sense to fix a behaviour that never worked, block it instead.
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Jul 10, 2025
This will be unnecessary once phpGH-19089 is merged because we always will have a valid objmap object.
Girgias
approved these changes
Jul 11, 2025
Comment on lines
+49
to
+51
| . Cloning a DOMNamedNodeMap, DOMNodeList, Dom\NamedNodeMap, Dom\NodeList, | ||
| Dom\HTMLCollection, and Dom\DtdNamedNodeMap. This never actually resulted | ||
| in a working object, so the impact should actually be zero. |
There was a problem hiding this comment.
Missing some words in the upgrading entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never worked and creates a broken object,
and on master can cause a crash with foreach.
It makes no sense to fix a behaviour that never worked, block it instead.