Skip to content

Conversation

@ydah
Copy link
Contributor

@ydah ydah commented Jul 13, 2025

Just use YYSIZE_T in Zend/zend_language_parser.y

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's much point in this. My understanding is that this macro exists for systems that do not (yet) define the size_t type? However, PHP requires at least C99 so size_t is always available.

@ydah
Copy link
Contributor Author

ydah commented Jul 13, 2025

Yes, I share that understanding.
This is simply a cosmetic change - as shown below, YYSIZE_T is size_t, so this is a change to unify the type representation.

#define YYSIZE_T size_t

If you judge that this change is meaningless, please feel free to close the PR. Thank you for reviewing!

@nielsdos
Copy link
Member

Alright, I'll close this then, thanks anyway!

@nielsdos nielsdos closed this Jul 13, 2025
@ydah ydah deleted the use-yysize_t branch July 13, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants