Various ext/uri fixes #19132
Closed
Various ext/uri fixes #19132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes are cherry-picked: - lexbor/lexbor@c608466 core/str.c: Fix undefined behavior in function lexbor_str_append - lexbor/lexbor@92260fd URL: fixed hostname setter if port is specified.
Both RFC 3986 and WHATWG support empty hosts
kocsismate
force-pushed
the
ext-url-fixes
branch
from
83f858a to
aeb9cd4
Compare
TimWolla
approved these changes
Jul 15, 2025
I'm also noticing that we forgot to add a NEWS entry for ext/uri in the first place for Alpha 1. We should add ext/uri to UPGRADING, though. |
|
Ah, and please adjust the PR title before merging to properly summarize the changes. |
nielsdos
approved these changes
Jul 15, 2025
|
I'm also noticing that we forgot to add a NEWS entry for ext/uri in the first place for Alpha 1. We should add ext/uri to UPGRADING, though. Yes. I planned to write the upgrading note when all the changes are there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits can be separately reviewed.