Skip to content

hash: Use zend_string_efree() where possible #19137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

hash: Use zend_string_efree() where possible #19137

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d84f07
hash: Use zend_string_efree() where possible
nielsdos Jul 15, 2025
94ec657
Forgot this
nielsdos Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/hash/hash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ static void php_hash_do_hash(

php_hash_bin2hex(ZSTR_VAL(hex_digest), (unsigned char *) ZSTR_VAL(digest), ops->digest_size);
ZSTR_VAL(hex_digest)[2 * ops->digest_size] = 0;
zend_string_release_ex(digest, 0);
zend_string_efree(digest);
RETURN_NEW_STR(hex_digest);
}
}
Expand Down Expand Up @@ -568,7 +568,7 @@ static void php_hash_do_hash_hmac(

php_hash_bin2hex(ZSTR_VAL(hex_digest), (unsigned char *) ZSTR_VAL(digest), ops->digest_size);
ZSTR_VAL(hex_digest)[2 * ops->digest_size] = 0;
zend_string_release_ex(digest, 0);
zend_string_efree(digest);
RETURN_NEW_STR(hex_digest);
}
}
Expand Down Expand Up @@ -829,7 +829,7 @@ PHP_FUNCTION(hash_final)

php_hash_bin2hex(ZSTR_VAL(hex_digest), (unsigned char *) ZSTR_VAL(digest), digest_len);
ZSTR_VAL(hex_digest)[2 * digest_len] = 0;
zend_string_release_ex(digest, 0);
zend_string_efree(digest);
RETURN_NEW_STR(hex_digest);
}
}
Expand Down