Skip to content

Remove redundant operations from zend_llist_clean() #19143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Remove redundant operations from zend_llist_clean() #19143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Zend/zend_llist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ ZEND_API void zend_llist_destroy(zend_llist *l)
ZEND_API void zend_llist_clean(zend_llist *l)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a long-standard todo to just remove this function since it does the same as the _destroy version, and this just makes it clearer - is there a reason not to remove it now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More code churn for third party extensions.

{
zend_llist_destroy(l);
l->head = l->tail = NULL;
}


Expand Down