Add missing hooks JIT restart code #19207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Jul 31, 2025
| } | ||
| } | ||
| } ZEND_HASH_FOREACH_END(); | ||
| } |
There was a problem hiding this comment.
Looks good, but maybe this should use zend_foreach_op_array() instead. It's not currently ZEND_API though.
There was a problem hiding this comment.
Maybe something for master
| if (prop->hooks[i]) { | ||
| op_array = &prop->hooks[i]->op_array; | ||
| ZEND_ASSERT(op_array->type == ZEND_USER_FUNCTION); | ||
| if (!(op_array->fn_flags & ZEND_ACC_TRAIT_CLONE)) { |
There was a problem hiding this comment.
Why is this condition not necessary for normal class methods?
There was a problem hiding this comment.
The condition is not necessary for this loop either. It's just an optimization we could apply to the other place too
There was a problem hiding this comment.
Okay, makes sense. Thanks for the clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.