Skip to content

Fix _pdo_pgsql_trim_message bad access #19239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+7 −1
Closed

Fix _pdo_pgsql_trim_message bad access #19239

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8940e3
Fix _pdo_pgsql_trim_message bad access
dixyes Jul 25, 2025
9ed16b6
Add compiler hint
dixyes Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ext/pdo_pgsql/pgsql_driver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,14 @@ static bool pgsql_handle_in_transaction(pdo_dbh_t *dbh);

static char * _pdo_pgsql_trim_message(const char *message, int persistent)
{
size_t i = strlen(message)-1;
size_t i = strlen(message);
char *tmp;
if (i == 0) {
tmp = pemalloc(1, persistent);
tmp[0] = '\0';
return tmp;
}
--i;

if (i>1 && (message[i-1] == '\r' || message[i-1] == '\n') && message[i] == '.') {
--i;
Expand Down
Loading