Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
uniqid
waits until the current microsecond has been changed until the previous call.This PR changes this logic instead of waiting until the current microsecond changes, it simply increments in case the current time is <= the previous.
This makes
uniqid
unaffected by time changes (like ntp) and also it's faster (if called very often) due to less system calls.A simple benchmark:
BEFORE: 100911477ns
AFTER: 57341969ns