ext/intl: update C to C++ step2. #19294
Merged
+87
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Aug 6, 2025
ext/intl/msgformat/msgformat_data.h
Outdated
| int tz_set; /* if we've already the time zone in sub-formats */ | ||
| } msgformat_data; | ||
|
|
||
| msgformat_data* msgformat_data_create( void ); |
There was a problem hiding this comment.
Why not include this one too? Otherwise it becomes a bit difficult to track which ones fall under extern "C" and which ones don't
| @@ -0,0 +1,51 @@ | |||
| /* | |||
| +----------------------------------------------------------------------+ | ||
| */ | ||
|
|
||
| #ifdef __cplusplus |
There was a problem hiding this comment.
Well this is a .cpp file, so surely this is true? (same below)
There was a problem hiding this comment.
ah yes I probably copied/pasted from somewhere else :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.