Fix GH-19311: Unexpected path truncation of files contained in a tar file by PharData::extractTo() #19322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
force-pushed
the
phar-pax
branch
3 times, most recently
from
46a6742 to
98df7e9
Compare
ndossche
force-pushed
the
phar-pax
branch
5 times, most recently
from
a4f46d6 to
9d9281c
Compare
Girgias
approved these changes
Oct 25, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I think this is correct from reading the spec and the code. I don't really know tar, so I didn't attempt to craft something that might break.
It might be an idea to expose this to some sort of fuzzer?
Member
There was a problem hiding this comment.
Possibly move where the bail: label is? It is somewhat confusing that we go "back up" to do error handling rather than the usual "go to end of function" style for error handling. As I needed to look up the full function code to locate the label.
May be a follow-up PR/commit or be a new commit in this change set.
| goto next; | ||
| /* Process global/file pax header: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/pax.html */ | ||
| if (!old && hdr->typeflag == TAR_GLOBAL_HDR) { | ||
| size = (size + 511) & ~511; |
Member
There was a problem hiding this comment.
Can you explain what this line does actually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a PoC