-
Notifications
You must be signed in to change notification settings - Fork 8k
Zend: Deprecate non-canonical cast names #19372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd4a82e to
b7633c0
Compare
ndossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some mixes between tabs/spaces in the parser .y file, other than that looks good
b7633c0 to
59b9ff2
Compare
I guess you meant the |
ndossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this LGTM
Question: shouldn't it say non-canonical instead of non canonical ? i.e. with a hyphen?
It should indeed, nicely spotted again. :) Will fix :) |
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_non-standard_cast_names
Effectively copied: e41b7f6