Skip to content

Fix GH-19397: mb_list_encodings() can cause crashes on shutdown #19405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GH-19397: mb_list_encodings() can cause crashes on shutdown #19405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e3369
Fix GH-19397: mb_list_encodings() can cause crashes on shutdown
nielsdos Aug 7, 2025
e879ead
Cleaner
nielsdos Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ext/mbstring/mbstring.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,8 +1165,10 @@ PHP_RSHUTDOWN_FUNCTION(mbstring)
MBSTRG(outconv_state) = 0;

if (MBSTRG(all_encodings_list)) {
GC_DELREF(MBSTRG(all_encodings_list));
zend_array_destroy(MBSTRG(all_encodings_list));
if (GC_DELREF(MBSTRG(all_encodings_list)) == 0) {
/* must be *array* destroy to remove from GC root buffer and free the hashtable itself */
zend_array_destroy(MBSTRG(all_encodings_list));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use zend_array_release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to avoid the immutability check, but sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact that's what I proposed initially #19397 (comment)

MBSTRG(all_encodings_list) = NULL;
}

Expand Down
11 changes: 11 additions & 0 deletions ext/mbstring/tests/gh19397.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--TEST--
GH-19397 (mb_list_encodings() can cause crashes on shutdown)
--EXTENSIONS--
mbstring
--FILE--
<?php
$doNotDeleteThisVariableAssignment = mb_list_encodings();
var_dump(count($doNotDeleteThisVariableAssignment) > 0);
?>
--EXPECT--
bool(true)
Loading