Skip to content

ext/tidy: throwing exception instead of warning for php calls. #19417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/tidy: throwing exception instead of warning for php calls. #19417

wants to merge 1 commit into from
+48 −22

Conversation

@devnexen
Copy link
Member

@devnexen devnexen commented Aug 8, 2025

Also using less generic exception type while at it.

@devnexen
ext/tidy: throwing exception instead of warning for php calls.
5948670 
Also using less generic exception type while at it.
@devnexen devnexen marked this pull request as ready for review August 8, 2025 12:16
@devnexen devnexen requested a review from kocsismate as a code owner August 8, 2025 12:16
@nielsdos
Copy link
Member

This probably needs an RFC

@devnexen
Copy link
Member Author

ah yes the "new" exception falls into the category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees

No one assigned

Labels

Extension: tidy Status: Requires RFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devnexen @nielsdos