Skip to content

ext/pdo_pgsql: Deprecate PDO::PGSQL_TRANSACTION* constants. #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+44 −6
Open

ext/pdo_pgsql: Deprecate PDO::PGSQL_TRANSACTION* constants. #19444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f147f2
ext/pdo_pgsql: Deprecate PDO::PGSQL_TRANSACTION* constants.
devnexen Aug 10, 2025
dc12c23
fix build
devnexen Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/pdo_pgsql/pdo_pgsql.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include "php.h"
#include "php_ini.h"
#include "zend_attributes.h"
#include "ext/standard/info.h"
#include "ext/pdo/php_pdo.h"
#include "ext/pdo/php_pdo_error.h"
Expand Down
5 changes: 5 additions & 0 deletions ext/pdo_pgsql/pdo_pgsql.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,23 @@ class Pgsql extends \PDO
#endif

/** @cvalue PGSQL_TRANSACTION_IDLE */
#[\Deprecated(since: '8.5', message: "as it has no effect")]
public const int TRANSACTION_IDLE = UNKNOWN;

/** @cvalue PGSQL_TRANSACTION_ACTIVE */
#[\Deprecated(since: '8.5', message: "as it has no effect")]
public const int TRANSACTION_ACTIVE = UNKNOWN;

/** @cvalue PGSQL_TRANSACTION_INTRANS */
#[\Deprecated(since: '8.5', message: "as it has no effect")]
public const int TRANSACTION_INTRANS = UNKNOWN;

/** @cvalue PGSQL_TRANSACTION_INERROR */
#[\Deprecated(since: '8.5', message: "as it has no effect")]
public const int TRANSACTION_INERROR = UNKNOWN;

/** @cvalue PGSQL_TRANSACTION_UNKNOWN */
#[\Deprecated(since: '8.5', message: "as it has no effect")]
public const int TRANSACTION_UNKNOWN = UNKNOWN;

public function escapeIdentifier(string $input): string {}
Expand Down
44 changes: 38 additions & 6 deletions ext/pdo_pgsql/pdo_pgsql_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.