Fix GH-15496: Fix accessing NULL pointer on output handler stack #19446
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
output-asan-err
branch
2 times, most recently
from
88a94f8 to
d37cd68
Compare
|
Unfortunately it doesn't fix the problem on Windows... 🤔 |
alexandre-daubois
force-pushed
the
output-asan-err
branch
from
d37cd68 to
07e1a7b
Compare
alexandre-daubois
force-pushed
the
output-asan-err
branch
from
262d2df to
525f5fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15496
This PR prevents
zend_stack_push()from being called when thePHP_OUTPUT_ACTIVATEDflag is cleared byphp_output_deactivate(). The new test case also crashes on branch PHP-8.3 and is passing with this fix.