Fix #47728: Add some missing PKCS7 constants #19450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds PKCS7_NOSMIMECAP, PKCS7_CRLFEOL, PKCS7_NOCRL and PKCS7_NO_DUAL_CONTENT constants. They might be potentially useful in some scenarious. Test is not added as it is not clear if there is much need for those and it would require much bigger effort just to test OpenSSL functionality.
bukka
force-pushed
the
openssl_bug47728_pkcs7_constants
branch
from
f3a0ece to
32ae9ed
Compare
bukka
changed the title
bukka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding those constant that might have some use cases. It's a bit of an edge case and not sure if anyone needs them (it was requested a long time ago) so I'm not going to bother with tests as they would just test OpenSSL functionality and require some specific conditions so it would be probably waste of my time.