Remove references to ODBCVER and assume ODBC 3.x #19453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NattyNarwhal
force-pushed
the
remove-odbcver
branch
from
caa5bc3 to
dd7f861
Compare
Girgias
approved these changes
Aug 12, 2025
|
Just added UPGRADING comments and removed some useless defines on top of this, LMK if this still is good. |
This should also go into NEWS (for Beta 2). As for this change, I'm not qualified to meaningfully review this, but I'm not seeing any obvious issues. As per https://externals.io/message/128453, I'm requesting a RM review. |
`SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`, `SQLGetConnectAttr`, and `SQLSetStmtAttr` instead. (This is based on phpGH-17556, but just assumes ODBC 3.x.)
We don't need to support the old way of doing it.
Again, no need for the version specific wrapper
NattyNarwhal
force-pushed
the
remove-odbcver
branch
from
598acab to
3b00b61
Compare
DanielEScherzer
approved these changes
Aug 12, 2025
|
@NattyNarwhal the squashed commit message contains |
|
Oops, I thought that only applied to the first line of the commit. I'll take care to remove these from future squashed commit messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the approved RFC. This also includes (and obsoletes) GH-17556, since we can safely assume that these functions are available in ODBC 3.x.