ci: enable _GLIBCXX_ASSERTIONS c++ flags on debug builds. #19497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
requested changes
Aug 16, 2025
TimWolla
reviewed
Aug 16, 2025
devnexen
force-pushed
the
ci_glibcxx_assertions
branch
from
d58ba17 to
1eaabf2
Compare
|
Should I ask the RM on this ? |
I don't think this is necessary for CI improvement. They've always happened as necessary and they do not affect the “external outcome”. |
Enable additional C++ runtime checks for the intl extensions. Basically, out-of-bounds accesses on vector or strings, undefined behavior on iterators.
devnexen
force-pushed
the
ci_glibcxx_assertions
branch
from
1eaabf2 to
2ebc07c
Compare
TimWolla
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable additional C++ runtime checks for the intl extensions. Basically, out-of-bounds accesses on vector or strings, undefined behavior on iterators.