Fix OSS-Fuzz #439125710: Pipe cannot be used in write context #19505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Aug 16, 2025
There was a problem hiding this comment.
Thanks!
Side-note: I looked through the uses of ZEND_AST_CALL in zend_compile.c, and I think the same is necessary for zend_compile_var_inner() (the if (CG(memoize_mode) != ZEND_MEMOIZE_NONE) { branch). This will ensure (1 |> foo(..))->bar ??= 2 doesn't execute foo() twice.
Edit: Nevermind, it seems this is disallowed (https://3v4l.org/KPGL2/rfc#vgit.master, Cannot use temporary expression in write context), though I don't completely see why. Edit 2: Ah, likely because pipes are not considered variables, but plain function calls are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.