Skip to content

Conversation

mvorisek
Copy link
Contributor

igbinary ext is very popular and more popular than some extensions already tested.

@mvorisek mvorisek requested a review from TimWolla as a code owner August 18, 2025 22:38
@mvorisek
Copy link
Contributor Author

Should pass CI after the latest changes to the igbinary repo.

@remicollet
Copy link
Member

Should pass CI after the latest changes to the igbinary repo.

igbinary is still not compatible with 8.5.0RC1
25 failed tests, mostly because of __sleep, __wakeup, report_memleaks deprecations

@nielsdos
Copy link
Member

The sleep and wakeup deprecations will be fixed most likely as https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup will likely pass.
I'd then prefer to wait until igbinary/igbinary#399 is merged

@iluuu1994
Copy link
Member

IMO, this build has not paid off. The only errors we have caught were known API breaks, which are always annoying to deal with, having to ping upstream maintainers and temporarily disabling builds. I'd honestly rather drop the whole thing, and especially not add more extensions that are not super well maintained.

@Girgias
Copy link
Member

Girgias commented Sep 30, 2025

I think that this build should be moved to a different repo, and maybe even run on a weekly basis rather than nightly, as API break impact are useful, but it shouldn't be breaking our builds...

@mvorisek
Copy link
Contributor Author

I'd then prefer to wait until igbinary/igbinary#399 is merged

The PR has been merged.

IMO, this build has not paid off...

I think that this build should be moved to a different repo...

igbinary ext is very popular and more popular than some extensions already tested.

I would be happy if this PR can be merged as is and if these extensions are wanted to be tested in "weekly", then they can be moved together at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants