Skip to content

[Fix] parse_url: don’t treat colon in path as port #19527 #19528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Fix] parse_url: don’t treat colon in path as port #19527 #19528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions ext/standard/tests/url/gh12703.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
--TEST--
GH-12703 parse_url() return false on absolute path containing ':' and no query string.
--FILE--
<?php
var_dump(
parse_url('/page:1'),
parse_url('/page:1', \PHP_URL_SCHEME),

// Working example for context.
parse_url('/page:1?foo=bar'),

// Examples from similar GH issue (7890)
parse_url('//www.examle.com/foo:65535/'),
parse_url('//www.examle.com:8080/foo:65535/'),
);

?>
--EXPECT--
array(1) {
["path"]=>
string(7) "/page:1"
}
NULL
array(2) {
["path"]=>
string(7) "/page:1"
["query"]=>
string(7) "foo=bar"
}
array(2) {
["host"]=>
string(14) "www.examle.com"
["path"]=>
string(11) "/foo:65535/"
}
array(3) {
["host"]=>
string(14) "www.examle.com"
["port"]=>
int(8080)
["path"]=>
string(11) "/foo:65535/"
}
3 changes: 3 additions & 0 deletions ext/standard/url.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,10 @@ PHPAPI php_url *php_url_parse_ex2(char const *str, size_t length, bool *has_port
p = e + 1;
pp = p;

const char *first_slash = memchr(s, '/', ue - s);

while (pp < ue && pp - p < 6 && isdigit(*pp)) {
if (first_slash && pp >= first_slash) break;
pp++;
}

Expand Down