Skip to content

Fix PHP 8.5 recursive tokenization during token_get_all #19547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
+67 −0
Closed

Fix PHP 8.5 recursive tokenization during token_get_all #19547

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a55bf78
Add test showing current behaviour
kubawerlos Aug 21, 2025
43a7a9a
Update test and add fix by `arnaud-lb`
kubawerlos Aug 21, 2025
101cb54
Update ext/tokenizer/tests/gh19507.phpt
kubawerlos Aug 22, 2025
1126337
Review updates
kubawerlos Aug 22, 2025
09bda24
Fix `Zend/zend_language_scanner.l`
kubawerlos Aug 22, 2025
cc20668
Merge branch 'master' into fix_19507
kubawerlos Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ext/tokenizer/tests/bug19507.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
--TEST--
Bug #19507: Recursive tokenization during `token_get_all` result on error
--EXTENSIONS--
tokenizer
--FILE--
<?php

set_error_handler(function (int $errno, string $msg) {
eval('123;');
echo 'error handler called: ', $msg, "\n";
});


$tokens = PhpToken::tokenize('<?php (double) $x;', TOKEN_PARSE);
foreach ($tokens as $token) {
echo $token->getTokenName(), "\n";
}

--EXPECT--
error handler called: Non-canonical cast (double) is deprecated, use the (float) cast instead
T_OPEN_TAG
T_LNUMBER
;
T_DOUBLE_CAST
T_WHITESPACE
T_VARIABLE
;