Skip to content

ext/intl: Add #[\Deprecated] to U_MULTIPLE_DECIMAL_SEPERATORS constant #19564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

ext/intl: Add #[\Deprecated] to U_MULTIPLE_DECIMAL_SEPERATORS constant #19564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d6d1cc
ext/intl: Add #[\Deprecated] to U_MULTIPLE_DECIMAL_SEPERATORS constant
DanielEScherzer Aug 23, 2025
fe562dc
Remove unneeded comment
DanielEScherzer Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/intl/common/common.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,9 +425,9 @@
/**
* Typo: kept for backward compatibility. Use U_MULTIPLE_DECIMAL_SEPARATORS
* @var int
* @deprecated
* @cvalue U_MULTIPLE_DECIMAL_SEPERATORS
*/
#[\Deprecated(since: '8.3', message: 'use U_MULTIPLE_DECIMAL_SEPARATORS instead')]
const U_MULTIPLE_DECIMAL_SEPERATORS = UNKNOWN;
/**
* @var int
Expand Down
12 changes: 10 additions & 2 deletions ext/intl/common/common_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ext/intl/common/common_enum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
// Fix build on Windows/old versions of ICU
#include <stdio.h>

extern "C" {
#include <zend_attributes.h>
}

#include "common_enum.h"
#include "common_arginfo.h"

Expand Down
15 changes: 15 additions & 0 deletions ext/intl/tests/deprecated_U_MULTIPLE_DECIMAL_SEPERATORS.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
U_MULTIPLE_DECIMAL_SEPERATORS is deprecated
--EXTENSIONS--
intl
--FILE--
<?php
var_dump(U_MULTIPLE_DECIMAL_SEPERATORS);
var_dump(constant('U_MULTIPLE_DECIMAL_SEPERATORS'));
?>
--EXPECTF--
Deprecated: Constant U_MULTIPLE_DECIMAL_SEPERATORS is deprecated since 8.3, use U_MULTIPLE_DECIMAL_SEPARATORS instead in %s on line %d
int(65793)

Deprecated: Constant U_MULTIPLE_DECIMAL_SEPERATORS is deprecated since 8.3, use U_MULTIPLE_DECIMAL_SEPARATORS instead in %s on line %d
int(65793)